Fix: Prevent panic on scanner initialization error #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes - Add early returns in NewScanner goroutines to prevent execution continuation after errors - Fix panic in NewScannerDBF where nil scanner header was accessed on error - Ensure consistent error handling across SHP, DBF, and SHX scanner initialization
farisdewantoro-bvt
approved these changes
Jan 22, 2026
Owner
|
Thank you for the PR. There is still a race in the code, which I will fix in a follow-up PR. |
Owner
|
I've tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @twpayne thanks for the lib
but there is issue on scanner when dbf error it cause panic.
Changes
How to reproduce: