feat: add @IsStrictlyOptional() decorator filtering only missing undefined values#2632
Open
ehenon wants to merge 3 commits intotypestack:developfrom
Open
feat: add @IsStrictlyOptional() decorator filtering only missing undefined values#2632ehenon wants to merge 3 commits intotypestack:developfrom
@IsStrictlyOptional() decorator filtering only missing undefined values#2632ehenon wants to merge 3 commits intotypestack:developfrom
Conversation
@IsActuallyOptional() decorator filtering only missing undefined values@IsStrictlyOptional() decorator filtering only missing undefined values
|
I think it makes more sense to use this decorator in the way I suggested. My view of “optional” in a DTO is: if the property is not present in the request body, validation should be skipped; if it is present (even if null or undefined), validation should run. Using propertyName in object achieves this behavior: Property absent → skip validation Property present → run validation This way, the decorator better reflects the semantic meaning of “optional” and avoids the confusion of skipping validation only for undefined, which doesn’t fully cover real-world use cases. |
|
yes, I need this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As mentioned/discussed in some issues and PRs, proposal to add a new decorator based on the same philosophy as
@IsOptional(), but filtering only values that are actually missing (=== undefined). Equivalent to@ValidateIf((o, v) => v !== undefined), but more direct and explicit.Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesReferences
references #491, #2615, #686