feat: add an option to IsObject to exclude functions from object checks#2655
Open
niskyB wants to merge 2 commits intotypestack:developfrom
Open
feat: add an option to IsObject to exclude functions from object checks#2655niskyB wants to merge 2 commits intotypestack:developfrom
niskyB wants to merge 2 commits intotypestack:developfrom
Conversation
Functions are objects in js therefore isObject should treat functions as objects by JS standard. |
Author
|
Could you please check this again? @Setitch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IsObject returned true for functions despite the documented behavior. This PR resolves the issue by introducing an option to exclude functions from object checks.
Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpassesFixes
fixes #2515