Skip to content

deps: upgraded dependency #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgoldstein0 merged 5 commits into from
Mar 26, 2025
Merged

deps: upgraded dependency #89

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ebfdd4
deps: upgraded dependency
ramisback Sep 26, 2024
721a0e8
fix: go version downgraded to latest stable version
ramisback Jan 31, 2025
a904cc3
refactor: replaced deprecated ioutil with os package
ramisback Jan 31, 2025
6faf1d1
Merge branch 'master' into dependency_upgrade
dgoldstein0 Mar 26, 2025
a5e347c
Update parser.go to fix bad merge
dgoldstein0 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
module github.com/ua-parser/uap-go

go 1.23.1
Copy link
Contributor

@pior pior Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the policy regarding Go version support?

I guess we don't want to force everyone to use the latest Go version?

Copy link
Contributor Author

@ramisback ramisback Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the go directive in go.mod to specify a lower, stable Go version. This change is backward-compatible, as go.mod ensures dependencies are tied to specific commits. However, to enhance backward compatibility and provide a clearer upgrade path, we should consider implementing semantic versioning for the library


require (
github.com/hashicorp/golang-lru v0.5.4
gopkg.in/yaml.v2 v2.2.1
github.com/hashicorp/golang-lru v1.0.2
gopkg.in/yaml.v3 v3.0.1
)
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
github.com/hashicorp/golang-lru v0.5.4 h1:YDjusn29QI/Das2iO9M0BHnIbxPeyuCHsjMW+lJfyTc=
github.com/hashicorp/golang-lru v0.5.4/go.mod h1:iADmTwqILo4mZ8BN3D2Q6+9jd8WM5uGBxy+E8yxSoD4=
github.com/hashicorp/golang-lru v1.0.2 h1:dV3g9Z/unq5DpblPpw+Oqcv4dU/1omnb4Ok8iPY6p1c=
github.com/hashicorp/golang-lru v1.0.2/go.mod h1:iADmTwqILo4mZ8BN3D2Q6+9jd8WM5uGBxy+E8yxSoD4=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/yaml.v2 v2.2.1 h1:mUhvW9EsL+naU5Q3cakzfE91YhliOondGd6ZrsDBHQE=
gopkg.in/yaml.v2 v2.2.1/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
8 changes: 4 additions & 4 deletions uaparser/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"sync/atomic"
"time"

"gopkg.in/yaml.v2"
"gopkg.in/yaml.v3"
)

type RegexesDefinitions struct {
Expand Down Expand Up @@ -139,9 +139,9 @@ type Parser struct {
cache *cache

RegexesDefinitions
Mode int
UseSort bool
debugMode bool
Mode int
UseSort bool
debugMode bool
}

const (
Expand Down
2 changes: 1 addition & 1 deletion uaparser/parsing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"log"
"testing"

"gopkg.in/yaml.v2"
"gopkg.in/yaml.v3"
)

var testParser *Parser
Expand Down