Updated the run_simulation_yaml.py file#23
Open
ballaswetha wants to merge 2 commits intouber-common:masterfrom
Open
Updated the run_simulation_yaml.py file#23ballaswetha wants to merge 2 commits intouber-common:masterfrom
ballaswetha wants to merge 2 commits intouber-common:masterfrom
Conversation
The slack alerting code was not working as there was a confusion between the variable named json and module named json. I replaced the variable with json_data which fixed the issue. The code is still commented out.
Update run_simulation_yaml.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Slack alerting was enabled, the following error message was displayed - local variable 'json' referenced before assignment
The issue appears to be using the word "json" as a variable and also module. I replaced "json" with "json_data" and that fixed the issue. The code is still commented out, in case folks don't want to use Slack alerting.