Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds OpenTelemetry distributed tracing support to the build-index tag server's putTag operation. The changes enable tracing of Docker push operations through the system, making it easier to debug and monitor performance.
Changes:
- Adds a new
WithTraceContextlogging utility function that extracts trace_id and span_id from context - Implements OpenTelemetry tracing in the putTagHandler with span lifecycle management and error recording
- Updates dependencies to include OpenTelemetry packages (v1.21.0 for core, v0.46.0 for HTTP instrumentation)
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/log/log.go | Adds WithTraceContext helper function to include trace_id and span_id in logs |
| build-index/tagserver/server.go | Adds tracer field to Server struct, applies tracing middleware to PUT endpoint, implements span management in putTagHandler with attributes and error recording |
| build-index/cmd/cmd.go | Initializes OpenTelemetry tracer and passes it to the server |
| build-index/tagserver/server_test.go | Updates test setup to use noop tracer for compatibility |
| go.mod | Adds OpenTelemetry dependencies and upgrades testify to v1.8.4 |
| go.sum | Updates checksums for new and upgraded dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Anton-Kalpakchiev
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds OpenTelemetry distributed tracing support to the build-index tag server's putTag operation. The changes enable tracing of Docker push operations through the system, making it easier to debug and monitor performance.