Rules for cleaning up case from switch statements of variables in an enum#397
Open
Satyam1749 wants to merge 1 commit intomasterfrom
Open
Rules for cleaning up case from switch statements of variables in an enum#397Satyam1749 wants to merge 1 commit intomasterfrom
Satyam1749 wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
I guess after #410 is merged, the limitation would no longer exist. |
ketkarameya
reviewed
Apr 6, 2023
Contributor
ketkarameya
left a comment
There was a problem hiding this comment.
Did my fix in 410 not work?
| # var v1: String { | ||
| # switch self { | ||
| # case .two, .two: | ||
| # return "one" |
Contributor
There was a problem hiding this comment.
We no longer need this right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains rule to cleanup any enum entry from all the variables in that enum. In swift, we use switch in enums to populate computed properties. These rules aims to cleanup any enum entry from all such variables.
example:
Before
After
case oneshould be cleaned up by a custom rule which needs to belong to groupenum_entry_cleanup, This will cleanup entry ofcase onefromvar v1.