Skip to content

Comments

Delete release_max_level_off feature for log crate#21

Merged
ming1 merged 1 commit intoublk-org:mainfrom
dtolnay-contrib:loglevel
Aug 13, 2025
Merged

Delete release_max_level_off feature for log crate#21
ming1 merged 1 commit intoublk-org:mainfrom
dtolnay-contrib:loglevel

Conversation

@dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Aug 13, 2025

This line in libublk's Cargo.toml makes it impossible to use the log crate from any application that depends on libublk, which seems misconceived.

Per log's documentation:

Libraries should avoid using the max level features because they’re global and can’t be changed once they’re set.

@ming1 ming1 merged commit 782fa5c into ublk-org:main Aug 13, 2025
4 checks passed
@dtolnay dtolnay deleted the loglevel branch August 13, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants