Merged
Conversation
Contributor
Author
|
Ugh: I was getting this to compile on s390x, now it's not, hold off on merging. |
Contributor
Author
|
This works if I do something like this on s390x: io-uring = { version = "^0.7", features = ["bindgen"] }But not on x86, and this doesn't work for s390x, but it does for x86 diff --git a/Cargo.toml b/Cargo.toml
index e613a62..f528df2 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -35,7 +35,15 @@ anyhow = "1.0.66"
[dependencies]
libc = "0.2"
-io-uring = {version="=0.7.9"}
+
+
+[target.'cfg(target_arch = "s390x")'.dependencies]
+io-uring = { version = "=0.7.9", features = ["bindgen"] }
+
+[target.'cfg(not(target_arch = "s390x"))'.dependencies]
+io-uring = { version = "=0.7.9" }
+
+As I'm using rust2rpm for packaging this needs to be self contained within the cargo build to keep this easier. |
see: tokio-rs/io-uring#333 Signed-off-by: Tony Asleson <tasleson@redhat.com>
b77e729 to
438aea3
Compare
Contributor
Author
|
Ok this is working now, I had to learn something new the hard way, ugh |
Collaborator
|
BTW, just be curious, the s390x build failure isn't triggered on Fedora rublk build: https://koschei.fedoraproject.org/package/rust-rublk?collection=f44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: tokio-rs/io-uring#333
resolves: #43