Merged
Conversation
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
When using io_uring with timeouts in the compress target, timeout CQEs were incorrectly being passed to ublk_wake_task(). Timeout events are internal housekeeping events used by ublk_reap_io_events_with_update_queue and should not trigger task wakeups. This could cause spurious task wakeups and potential issues with task scheduling, as the timeout user_data doesn't correspond to any actual waiting task. Fix this by checking if the CQE user_data matches TIMEOUT_USER_DATA and skipping the wake call for timeout events, while still waking tasks for all normal I/O completion events. Signed-off-by: Ming Lei <tom.leiming@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix one high rublk cpu utilization issue after running some IO on compress target.