Add support for letting janitor accept authenticated account renewal requests#364
Open
jonasbardino wants to merge 4 commits intonextfrom
Open
Conversation
jonasbardino
force-pushed
the
adjust/janitor-to-accept-account-renew-with-authenticated-password-change
branch
2 times, most recently
from
d011098 to
cefdf24
Compare
…optional password change if the renew request was explicitly authorized during submit. Useful to let users change password while account access is still active.
… let janitor automatically handle them whether password changed or not. Otherwise they would end up stuck in the "Nothing more to do for existing user XYZ" state with janitor repeatedly trying.
jonasbardino
force-pushed
the
adjust/janitor-to-accept-account-renew-with-authenticated-password-change
branch
from
cefdf24 to
c4b083b
Compare
jonasbardino
force-pushed
the
adjust/janitor-to-accept-account-renew-with-authenticated-password-change
branch
from
c4b083b to
dbc939e
Compare
jonasbardino
force-pushed
the
adjust/janitor-to-accept-account-renew-with-authenticated-password-change
branch
from
dbc939e to
523ea1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for letting janitor accept authenticated account renewal requests with optional password change, that is, account requests submitted while explicitly logged in. Useful to let users change password directly while their account access is still active.
IMPORTANT: this is tested to work in practice but we need another pass to assure authentication validity before review and merge.