store the last game state for end_of_round#8
Open
andquintero wants to merge 1 commit intoukoethe:masterfrom
Open
store the last game state for end_of_round#8andquintero wants to merge 1 commit intoukoethe:masterfrom
andquintero wants to merge 1 commit intoukoethe:masterfrom
Conversation
Collaborator
|
Thanks for the PR. To avoid off-by-one confusion, can you specify which state you expected? My idea was that the last game state is None (i.e. the state after the game ended), so I tried to pass the state the agent last took an action as last_game_state to end_of_round. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the
end_of_roundfunction, the last_game_state was actually the previous game state, this stores the real final game state