Fixed problems of compiling with Unikraft v0.12#4
Open
junyang-zh wants to merge 1 commit intounikraft:stagingfrom
Open
Fixed problems of compiling with Unikraft v0.12#4junyang-zh wants to merge 1 commit intounikraft:stagingfrom
junyang-zh wants to merge 1 commit intounikraft:stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to use mimalloc with Unikraft v0.12.0 (current stable version), and the mimalloc library doesn't compile. It seems that the
uk_threadstruct is modified after the original porting of mimalloc. Thus I made it work according to the context given.I only tested this fix on app-redis and app-helloworld with QEMU 4.2.1. It worked well for any memory sizes above 256M. :)
See the diff for details, it's simple. Forgive me if I did anything wrong.