Fix failure_cases index value for MultiIndex schema errors#2186
Merged
cosmicBboy merged 2 commits intounionai-oss:mainfrom Dec 12, 2025
Merged
Fix failure_cases index value for MultiIndex schema errors#2186cosmicBboy merged 2 commits intounionai-oss:mainfrom
cosmicBboy merged 2 commits intounionai-oss:mainfrom
Conversation
…s will have correct index values Signed-off-by: Adam Merberg <adam.merberg@equilibriumenergy.com>
Signed-off-by: Adam Merberg <adam.merberg@equilibriumenergy.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
===========================================
+ Coverage 81.51% 93.67% +12.16%
===========================================
Files 137 137
Lines 10895 10898 +3
===========================================
+ Hits 8881 10209 +1328
+ Misses 2014 689 -1325 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cosmicBboy
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression in #2103 where the
indexcolumn offailure_casesfor schema errors raised in validating a multiindex level only includes the level that failed validation, rather than the tuple of all multi-index values. The fix implemented here is to validate the level as a series indexed by the full multi-index. A unit test is also added to prevent similar regressions in the future.