Skip to content

feat: wide(logging)#4923

Closed
Flo4604 wants to merge 8 commits intomainfrom
feat/logging-overhaul
Closed

feat: wide(logging)#4923
Flo4604 wants to merge 8 commits intomainfrom
feat/logging-overhaul

Conversation

@Flo4604
Copy link
Member

@Flo4604 Flo4604 commented Feb 4, 2026

What does this PR do?

Inspired by

Tries to make use of wide logging so we have more context

example:

Feb  4 20:08:34.171 ERR middleware/errors.go:346 api error instanceID=api-dev platform=kubernetes region=unknown version=development error="random test error for wide events" requestId=req_B1cexRdZ publicMessage=""
Feb  4 20:08:34.172 ERR wide/event.go:199 POST /v2/keys.verifyKey instanceID=api-dev platform=kubernetes region=unknown version=development service_name=api error_locations=[/Users/florianeikel/Developer/unkeyed/unkey/svc/api/routes/v2_keys_verify_key/handler.go:64] error_type=platform request_id=req_B1cexRdZ host=127.0.0.1:7070 root_key_id=key_jokQjlen path=/v2/keys.verifyKey content_length=66 workspace_id=ws_local error_internal="random test error for wide events" status_code=500 duration_ms=1 sample_reason=error service_version=unkey:local user_agent=curl/8.18.0 method=POST error_code=err:unkey:application:unexpected_error region=unknown ip_address=127.0.0.1

Not sure if its logging too much but atleast its more than before e.g we know where the fault got wrapped and which endpoint who called us and more.

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read Contributing Guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand areas
  • Ran pnpm build
  • Ran pnpm fmt
  • Ran make fmt on /go directory
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Unkey Docs if changes were necessary

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboard Ready Ready Preview, Comment Feb 4, 2026 8:16pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
engineering Ignored Ignored Preview Feb 4, 2026 8:16pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/logging-overhaul

Comment @coderabbitai help to get the list of available commands and usage tips.

@Flo4604
Copy link
Member Author

Flo4604 commented Feb 4, 2026

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Flo4604
Copy link
Member Author

Flo4604 commented Feb 6, 2026

superceeded by #4949

@Flo4604 Flo4604 closed this Feb 6, 2026
@Flo4604 Flo4604 deleted the feat/logging-overhaul branch February 6, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant