Feature: CI refactor #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstract testing & linting code out to a separate file to reduce code duplication with the phoenix build workflow. Additionally add cargo deny checks.
The default behaviour for `cargo-deny`'s wildcard ban disallows path or git crates by default for compatibility with crates.io. Since this is a private crate, we should allow these.
Lots of cargo-deny fails that are trivial to fix were resolved and a common crate configuration was added in the root `Cargo.toml` for child crates to inherit.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CI infrastructure to improve dependency management, add build verification for the Phoenix board, and establish workspace-wide package configuration for consistency across all crates.
Changes:
- Adds
cargo-denyworkflow for dependency security and license compliance checks - Introduces a reusable build workflow and adds Phoenix build verification
- Establishes workspace-wide package metadata (version, authors, license) for all crates
- Migrates dependencies to use workspace inheritance for better consistency
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Adds workspace.package metadata and additional workspace dependencies (bitflags, num-traits, static_cell) |
| deny.toml | Uncomments and configures license allowlist, adds allow-wildcard-paths for path dependencies |
| boards/argus/Cargo.toml | Migrates to workspace package metadata and workspace dependencies |
| boards/argus/.cargo/config.toml | Adds cargo configuration for consistent build settings |
| boards/phoenix/Cargo.toml | Migrates to workspace package metadata and workspace dependencies |
| common/*/Cargo.toml | All common crates migrate to workspace package metadata and workspace dependencies |
| .github/workflows/build.yml | New reusable workflow for common build, lint, and test tasks |
| .github/workflows/phoenix-build.yml | New workflow for Phoenix board build verification |
| .github/workflows/deny.yml | New workflow for cargo-deny dependency checks |
| .github/workflows/argus-build.yml | Refactored to use the new reusable build workflow |
| Cargo.lock | Version updates and dependency cleanup reflecting workspace changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
There is sadly nothing we can do about atomic-polyfill being depreciated, as the latest version serde-csv-core depends on a version of heapless that depends on atomic-polyfill. |
Vortex148
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A buncha changes, including but limited to:
cargo-denyto check for vulnerabilities, license compatibility, and a bunch of other related dependency shenanigans (Closes Add cargo deny to build verification #41)cargo-denythat can be trivially fixed, and a couple other changes that bothered the CI checks (Closes See why the "Check for Formatting/Linting/Semantic Issues" github action has been failing #42)Cargo.tomlfor convenience