Open
Conversation
joemfb
reviewed
Oct 31, 2025
| // frame size, in words | ||
| // | ||
| c3_w wor_w = (len_w + 3) >> 2; | ||
| c3_w wor_w = (len_w + 3 + pad_w) >> 2; |
Collaborator
There was a problem hiding this comment.
I don't think we want or need to change the frame size to accomplish alignment. The frame size (in words) is the sizeof (in bytes), so it already accounts for any padding necessary to align an array of these frames. What's missing is the initial alignment of the base pointer (ie, cap_p). That needs to happen, and the result stored in top_p. The pile also needs an additional member to track and restore (in u3a_pile_done() the original, un-aligned cap.
Collaborator
|
We need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.