feat: add configurable vhost option for monitors#415
feat: add configurable vhost option for monitors#415vinayakjeet wants to merge 3 commits intourunc-dev:mainfrom
Conversation
✅ Deploy Preview for urunc canceled.
|
This change adds a 'vhost' configuration option to monitors. When enabled, it allows the use of vhost-net for improved network performance in QEMU. Fixes: urunc-dev#410 Signed-off-by: vinayakjeet <vinayakjeetog@gmail.com>
|
Hello @vinayakjeet , thank you for your contribution. Please fill the PR template correctly and fully. Also, please test your changes before submitting a PR. |
Signed-off-by: vinayakjeet <vinayakjeetog@gmail.com>
TestingThe following tests were run locally on WSL2 (Ubuntu 24.04, amd64):
I attempted to run All setup steps (Docker, containerd, systemd) were verified locally. Let me know if you would like me to re-test this on a native Linux host. |
cmainas
left a comment
There was a problem hiding this comment.
Hello @vinayakjeet ,
thank you for this PR, I have added a few initial comments. However, you can at least execute the tests that do not use devmapper and specifically check if the new option in the configuration does work as expected. In the e2e test cases you can see which are the ones that do not require devmapper https://github.com/urunc-dev/urunc/blob/main/tests/e2e/test_cases.go
You can run these tests with make test_ctr_{name_of_test}, same for any other tool
- Add explicit warning log when ParseBool fails for vhost value - Simplify VMMFactory.createFunc signature to pass vhost bool instead of full MonitorConfig Signed-off-by: vinayakjeet <vinayakjeetog@gmail.com>
Description
This change adds a configurable
vhostoption to monitors.When enabled for QEMU, it allows the use of
vhost-netto improve network performance.Related issues
Fixes
How was this tested?
make lintmake test_ctrLLM usage
Yes – LLMs were used for drafting code and clarifying implementation details.
All changes were reviewed and verified manually.
Checklist
make lint).make test_ctr).