feat: Make response status code configurable#53
Merged
shreddedbacon merged 2 commits intomainfrom Jul 24, 2025
Merged
Conversation
anothertobi
reviewed
Jul 24, 2025
anothertobi
left a comment
anothertobi
left a comment
There was a problem hiding this comment.
The logical change looks good 👍
Just one small thing for the naming: Using something like defaultHTTPResponseCode instead of defaultHTTPErrorCode would highlight that this is indeed the default response status code since it's used as the response code for all requests that don't specify a valid int X-Code header.
Contributor
Author
|
Good point! I'll update the naming accordingly. |
dimiechatz
changed the title
dimiechatz
changed the title
anothertobi
approved these changes
Jul 24, 2025
anothertobi
left a comment
anothertobi
left a comment
There was a problem hiding this comment.
LGTM 🚀
Leaving this for @shreddedbacon for a final review.
shreddedbacon
approved these changes
Jul 24, 2025
Member
shreddedbacon
left a comment
shreddedbacon
left a comment
There was a problem hiding this comment.
Thanks @dimiechatz and @anothertobi. All good from me, I'll release this and do a charts bump today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: https://amazeeio.atlassian.net/browse/PLAT-489
Changes
default-http-response-codeflag to make the default response status code configurable. The default value is set to404.