chore: support newer compose-go library with lagoon workarounds#304
Draft
shreddedbacon wants to merge 1 commit intomainfrom
Draft
chore: support newer compose-go library with lagoon workarounds#304shreddedbacon wants to merge 1 commit intomainfrom
shreddedbacon wants to merge 1 commit intomainfrom
Conversation
shreddedbacon
force-pushed
the
compose-go-latest-lagoon-fixes
branch
from
6defce0 to
bed8c56
Compare
shreddedbacon
force-pushed
the
compose-go-latest-lagoon-fixes
branch
from
bed8c56 to
4b95dcf
Compare
shreddedbacon
force-pushed
the
compose-go-latest-lagoon-fixes
branch
2 times, most recently
from
ffc9d9b to
57f33ec
Compare
shreddedbacon
force-pushed
the
compose-go-latest-lagoon-fixes
branch
3 times, most recently
from
e726122 to
5158162
Compare
shreddedbacon
force-pushed
the
compose-go-latest-lagoon-fixes
branch
from
5158162 to
f904135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the compose-go library to the latest version with lagoon workarounds for the more common issues.
Unfortunately, the
duplicate mappingerror is not a lagoon workaround, so introducing this into the build-deploy-tool will result in builds failing if those duplicate mapping keys error is encountered.Also,
env_filegot an update to allow for these to be optionally required by changing the structure of the yaml to support apathandrequiredfield. This will be handy in the future for when we eventually decide to fail builds and move towards consuming the upstreamcompose-golibrary directly. See workarounds in shreddedbacon/compose-go#5Closes
closes #252