Open
Conversation
HagerDakroury
force-pushed
the
feat/merge-ui-library
branch
from
4899b0e to
8000138
Compare
Add @ui-lib/* path alias to tsconfig.json pointing to src/ui-library/*. Replace all @/ imports within src/ui-library/ to @ui-lib/ to avoid conflicts with the app's existing @/ alias.
Move all CSS variables, theme tokens, and base layer rules from ui-library's index.css into the app's globals.css. Remove the @uselagoon/ui-library CSS import and delete the now-redundant index.css. App-specific :root overrides (--background, --foreground) are preserved in @layer base so they take precedence.
Replace all imports from the external @uselagoon/ui-library package with local path aliases: - @uselagoon/ui-library/schemas -> @/ui-library/schemas - @uselagoon/ui-library/dist/... -> @/ui-library/... - @uselagoon/ui-library -> @/ui-library
Add all dependencies that ui-library requires (radix-ui primitives, tanstack/react-table, class-variance-authority, shadcn utilities, recharts, zod, etc.) to lagoon-beta-ui's package.json.
Remove the external @uselagoon/ui-library dependency since its source is now merged locally. Remove the uilib:update script and strip the yarn uilib:update prefix from dev and build scripts.
Remove the external Chromatic refs block that pointed to the ui-library's separate Storybook. The stories glob already covers src/ui-library/stories/ so all ui-library stories are now included directly.
The initial bulk replacement only caught single-quoted imports. This fixes the remaining double-quoted @/ imports in ChangeFeed components and ActionButton story.
HagerDakroury
force-pushed
the
feat/merge-ui-library
branch
from
8000138 to
bf9dbaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged https://github.com/uselagoon/ui-library.
The package currently lives under
src/ui-library