Open
Conversation
Member
|
Here are some problems I see with doing this:
I agree that it would be much better to split these out to a different log sink. However that doesn't need to be elasticsearch and could be something much simpler since we don't need the multi-tenancy or the extra processing we currently do with fluentd in the logs-dispatcher. I've got some ideas for this 😄 Another thought: do we really need all these namespaces? one or two might be ok as a quick fix for your use-case? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a couple of cases where we really needed logs from system namespaces.
I'm not sure though if this is really the right way to do this. Basically we're sending many thousand of log entries to the elasticsearch which is also used by our customers.
If I would have time I probably would create a separate logging infrastructure for system logs from our clusters, but as we don't really have time I think the easiest right now is to just send them in the same place.
Any opinions @smlx ?