fix: --output-json no longer escapes for HTML context

[rocketeerbkw]

General Checklist

• Affected Issues have been mentioned in the Closing issues section
• Documentation has been written/updated
• PR title is ready for inclusion in changelog

The existing JSON renderer uses the default Go json.Marshal() which escapes content assuming it will be in an HTML context. This causes URLs to be invalid in a cli context.

Closing issues

n/a

[shreddedbacon]

#485 i think broke the output for this, this fixes it

index d61c07f..1f1d5e3 100644
--- a/pkg/output/main_test.go
+++ b/pkg/output/main_test.go
@@ -138,7 +138,8 @@ func TestRenderString(t *testing.T) {
        output := RenderString(testData, outputOptions)
        checkEqual(t, output, testSuccess1, " render string processing failed")
 
-       var testSuccess2 = `"Plain string message"`
+       var testSuccess2 = `"Plain string message"
+`
        outputOptions.JSON = true
 
        output = RenderString(testData, outputOptions)```

[shreddedbacon]

Needs some checking on the failure

[rocketeerbkw]

Since this changes how JSON is printed, it will probably break tests again with #486, if you wanna merge that one first.

[shreddedbacon]

Since this changes how JSON is printed, it will probably break tests again with #486, if you wanna merge that one first.

I'll let you rebase/fix as required for this one then. Once I get the notification of your update I'll run through the review again.