Conversation
|
I see you're just doing the filter to split by pipe. Even though the previous grep was doing regex pattern matching, splitting by pipe will solve the problem. But if other users have deployed the existing chart and are seeing that it does regex, then this filter will still fail. I see the thought process on this, but being regex I could put I think as this is an entirely new method of doing filtering, the old method of pulling in the filter from the helmchart should be deprecated. So instead of doing this we should probably change the chart to be, and make it clear these must be full repositories (or even the full filter value of And then updating the deployment to do something like this |
shreddedbacon
left a comment
There was a problem hiding this comment.
Minor thing in the dockerfile for the change to filters
|
Also seeing this message - may be worth disabling authentication check in here |
6be93e1 to
2ac9c4f
Compare
|
ok @CGoodwin90 - this is back! Couple of notes:
|
Cool, I'll take a look at it! |
0e4d881 to
aa194c8
Compare
aa194c8 to
98df40b
Compare
In conjunction with uselagoon/lagoon-charts#561
WIP - Rewrote in Go
Moved cmd directive to execute in Go.