feat: change build name for variable only deployments#4027
Merged
CGoodwin90 merged 4 commits intomainfrom Dec 9, 2025
Merged
Conversation
Overview
|
f96f7d9 to
c04d6e3
Compare
bomoko
requested changes
Dec 4, 2025
Contributor
bomoko
left a comment
There was a problem hiding this comment.
Looks good - I just wonder about the name of the function generating the build id
c04d6e3 to
71ef6f9
Compare
Contributor
|
@shreddedbacon - is this good to look at again? |
Member
Author
|
Yep, just as long as the merge requirements are not ignored, the other PR still needs review. |
bomoko
approved these changes
Dec 9, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
Description
Extends deployment type with a new field
buildTypethat is an enum, the default isBUILD, but also supportsVARIABLES. This will change depending on if the build has been flagged to be a variables only deployment. The existence of the variables only deployment flag also changes the name of the build to belagoon-variables-xyzinstead oflagoon-build-xyzto also differentiate in the list of deployments. TheCONTAINER_REGISTRYscope should be treated the same asBUILD, as it is only consumed during a build.Usage
An example of triggering a variables only deployment. This sets the build variable
LAGOON_VARIABLES_ONLYto true.Limitations
Variables only deployments have some limitations. Only
RUNTIMEandGLOBALscope are considered as being changed (GLOBALbecause it is consideredRUNTIMEandBUILD). However, if the variable being changed isGLOBALorBUILDand is required to influence the outcome of built images, or change behaviour of something during a build, then a full deployment would be required. In the event that aGLOBALscope is changed, only the runtime version of that variable will be updated in the environment.Requirements
This shouldn't be merged until uselagoon/build-deploy-tool#430 has been evaluated. The two are sort of linked together, merging this without the other just seems silly.