Support task files direct upload method#114
Merged
shreddedbacon merged 2 commits intomainfrom Jan 15, 2026
Merged
Conversation
shreddedbacon
approved these changes
Jan 15, 2026
Member
shreddedbacon
left a comment
shreddedbacon
left a comment
There was a problem hiding this comment.
I'd be surprised if anyone uses this anywhere outside of the default tasks that lagoon-core provides.
Verified this works with the CLI as a drop in replacement. All good for me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for uselagoon/lagoon#4017.
No API changes for existing
UploadFilesForTaskso downstream tools likelagoon-clidon't need any changes. Adds new functions to upload a single file and/or get the raw upload endpoint info (to facilitate parallelism in downstream tools).This is a breaking change when attempting to use older Lagoon versions which don't support direct upload method yet. We do track the lagoon version, and code comments/readme suggest to use the version for compatibility, so I considered forking
UploadFilesForTaskbased on the version number to support both api/direct upload methods. This isn't being done anywhere else that I found, and I'm not sure if the intent is for this logic is to exist in this library or in downstream tools, so I left it out.