fix: toggle focus mode do not reset editor height#5504
Open
lilonghe wants to merge 4 commits intousememos:mainfrom
Open
fix: toggle focus mode do not reset editor height#5504lilonghe wants to merge 4 commits intousememos:mainfrom
lilonghe wants to merge 4 commits intousememos:mainfrom
Conversation
Signed-off-by: longhe.li <lilonghe@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the editor height was not properly reset when exiting focus mode. After entering focus mode, writing content, and then exiting focus mode, the editor would remain at an incorrectly expanded height instead of recalculating to the appropriate size.
Changes:
- Added a
useEffecthook that triggersupdateEditorHeight()wheneverisFocusModechanges to ensure the editor height is recalculated when toggling between focus and normal modes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: longhe.li <lilonghe@outlook.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: longhe.li <lilonghe@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At editor, enter focus mode, and write something, then exit focus mode, the editor height is too high, didn't reset.
