Fixed nearly all remaining type errors

[PaulKlint]

STILL TODO:

1. error("Types Maybe[&T <: Tree] and Maybe[&A]::just(&A val) do not match",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/refactor/rename/Common.rsc|(3468,4,<86,4>,<86,8>),fixes=[],causes=[])
   [This could be an error in type instantiation in the type checker]

2. error("Cannot call changed with keyword arguments needsConfirmation` of type `bool, description` of type `str and label` of type `str, given definitions FileSystemChange(list[TextEdit]), FileSystemChange::changed(loc file, list[TextEdit] edits) or FileSystemChange::changed(loc file)",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/Templates.rsc|(2198,122,<55,25>,<55,147>),fixes=[],causes=[])
   [Simple error]

3. error("No definition found for anno, keywordfield or field top in type Module",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/Templates.rsc|(2499,3,<58,44>,<58,47>),fixes=[],causes=[])
   [Unclear]

4. error("Return type int expected, found num",|file:///Users/paulklint/git/rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/tests/rename/Benchmark.rsc|(4637,56,<72,15>,<72,71>),fixes=[],causes=[])
   [Simple error]

[toinehartman]

No definition found for anno, keywordfield or field top in type Module

On line 59 of

rascal-language-servers/rascal-lsp/src/main/rascal/lsp/lang/rascal/lsp/Templates.rsc

Lines 56 to 59 in ed39246

	} else if (m := parseModuleWithSpaces(f)) {
	// If an existing module was pasted, replace the module name
	edits += changed([replace(m.top.header.name.src, name)], label = "Moved module", description = "", needsConfirmation = true);
	}

Sounds like usethesource/rascal#2496. A work-around is to explicitly type m as start[Module] m on 57, which I will do.

[toinehartman]

Thanks! Looks good.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud