Prepares the removal of the final annotation (Tree@\loc), including its definition and all of its uses. PR to be merged when rascal-core project is stable.#1974
Draft
jurgenvinju wants to merge 15 commits intomainfrom
Conversation
… _only_ work for Eclipse. We can upgrade Eclipse to also use util::IDEServices and util::LanguageServer, or we can drop them as soon as we drop Eclipse
Member
Author
|
The
It has to run on the entire project to make sense as the refactoring is "dumb"; it does not follow name resolution links it just replaces all syntactical constructs in a consistent manner. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1974 +/- ##
========================================
- Coverage 49% 49% -1%
+ Complexity 6297 6244 -53
========================================
Files 664 665 +1
Lines 59558 59624 +66
Branches 8639 8645 +6
========================================
- Hits 29437 29294 -143
- Misses 27908 28140 +232
+ Partials 2213 2190 -23 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for some testing until we've decided it is a good time to merge; when rascal-core is stable.
lang::rascal::upgrade::UpgradeAnnotationsToKeywordParametersreportfrom this module first to see what the relevance and impact would beThis change impacts all projects with code that uses
Tree.\@loc; so that's a lot. It makes sense to document how to use the automated refactoring or to link this into a UI feature (lenses?) for easy-of-use.This branch does not remove the old feature yet for two reasons:
Tree@\locworks against a definition ofTree(loc src=|unknown:///|)! So everybody will have to runupdate(myProjectSourceFolder)anyway.Commits: