Fixed notices in QueryBuilderHandler#137
Open
skipperbent wants to merge 1 commit intousmanhalalit:masterfrom
Open
Fixed notices in QueryBuilderHandler#137skipperbent wants to merge 1 commit intousmanhalalit:masterfrom
skipperbent wants to merge 1 commit intousmanhalalit:masterfrom
Conversation
|
May it be possible for you to add a unit-test to show the bug / fix? This will make the source of Pixie more secure. |
Author
|
I think the fix is a bit small to create unit-testing for. If you want to reproduce the error yourself, it seems like there's it occurs when calling This is my query if you want to investigate any further yourself. $messages->whereNotNull('customer_id')->orderBy('created_date', 'DESC');
$updateQuery = $messages;
$messages = Message::table($messages->subQuery($messages, 'messages'));
$messages->orderBy('read');
$messages->orderBy('created_date', 'DESC');
$messages->groupBy('event_id');
$this->maxPages = ceil($messages->count() / $this->limit);
$this->page = input()->get('page', 0);
$messages->offset($this->page * $this->limit);
$messages->limit($this->limit);
$this->messages = $messages->all();
// Set messages as read
$updateQuery->update(['read' => 1]);Removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixed notices in
QueryBuilderHandlerclass when$row[0]is not set.