CT Code Coding scheme oid update#601
Open
oliveregger wants to merge 1 commit intousnistgov:developfrom
Open
Conversation
Collaborator
|
Hi Oliver,
PR 601 is not what I was expecting. By metadata files, I meant the XDS-I
test metadata files, for example: XDS-I-idc-a/metadata-IDCDEPT011-a.xml
<https://github.com/usnistgov/iheos-toolkit2/compare/develop?expand=1#diff-1d84cc33569c510561445123c9732d7f88fc7539e4c903658a8689bfcf0ff4c0>
.
The codes.xml should not be changed, only the test metadata needs to use
the correct combination of code, description, etc. The only problem was the
incorrect codingScheme. The current urn:connectathon:bppc:foundational:policy
must be reverted to the copy before the update, and the codingScheme should
be fixed to 1.2.840.10008.2.16.4.
Thanks,
Sunil
…On Fri, May 24, 2024 at 11:12 AM Oliver Egger ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#601
Commit Summary
- 98dad92
<98dad92>
CT Code Coding scheme oid update
File Changes
(1 file <https://github.com/usnistgov/iheos-toolkit2/pull/601/files>)
- *M* xdstools2/src/main/webapp/toolkitx/environment/default/codes.xml
<https://github.com/usnistgov/iheos-toolkit2/pull/601/files#diff-99f98da87abd5ca5a544c544872a66b9682c3d40b12d64ec857470884a9b1abd>
(6)
Patch Links:
- https://github.com/usnistgov/iheos-toolkit2/pull/601.patch
- https://github.com/usnistgov/iheos-toolkit2/pull/601.diff
—
Reply to this email directly, view it on GitHub
<#601>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASHCM3DZCF3FI5UX43WGJ3ZD5KGVAVCNFSM6AAAAABIHYJMSSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMYTKNRUHEZDIOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Collaborator
|
I will update the CodesUpdater tool to fix this issue automatically. |
skbhaskarla
pushed a commit
that referenced
this pull request
May 30, 2024
…stead of arbitary pick) feature to CodesUpdater tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.