Update mcr.py to avoid infrequent Nan error when working with small simple datasets#31
Open
RyanJMcCarty wants to merge 1 commit intousnistgov:masterfrom
Open
Update mcr.py to avoid infrequent Nan error when working with small simple datasets#31RyanJMcCarty wants to merge 1 commit intousnistgov:masterfrom
RyanJMcCarty wants to merge 1 commit intousnistgov:masterfrom
Conversation
In some dataset mcr.py will create a C_temp with Nan values. Where C is unknown and an SVD guess is provided for ST. I didn't look into the problem futher, but this fix does solve the issue if present, and if not present the added code adds infinitesimally to the total run time. Seems to be more of an issue in small datasets with very high S/N and somewhat small ST. If the Nan values are not removed, the script will crash at line 421
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some dataset mcr.py will create a C_temp with Nan values.
If the Nan values are not removed, the script will crash at line 421.
I encountered the Nan value problem where C is unknown and an SVD guess is provided for ST. I didn't look into the problem further, but this fix does solve the issue if present, and if not present the added function adds infinitesimally to the total run time. This problem Seems to be more of an issue in small datasets with very high S/N and somewhat small ST.
NOTE: This fix is really just a band aid. It corrects the problem, but does not fix the source.