Skip to content

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 3, 2026

smaller binary

@oech3 oech3 force-pushed the sorth branch 2 times, most recently from 846b442 to c2227a1 Compare February 3, 2026 21:36
@oech3
Copy link
Contributor Author

oech3 commented Feb 3, 2026

Needs #10692

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing oech3:sorth (92e6b39) with main (368230e)

Summary

✅ 284 untouched benchmarks
⏩ 38 skipped benchmarks1

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@oech3 oech3 marked this pull request as ready for review February 3, 2026 22:17
@oech3 oech3 force-pushed the sorth branch 2 times, most recently from 40f3aae to de76be7 Compare February 4, 2026 05:49
@oech3
Copy link
Contributor Author

oech3 commented Feb 4, 2026

Is fuzz/Cargo.lock related with this PR?

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

yeah, you should update cargo.lock too

@oech3

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/symlink. tests/tail/symlink is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@sylvestre
Copy link
Contributor

it regressed some tests

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/tty/tty-eof (fails in this run but passes in the 'main' branch)

@oech3 oech3 marked this pull request as draft February 4, 2026 14:37
@oech3
Copy link
Contributor Author

oech3 commented Feb 4, 2026

I think we should provide a small seed if -R --random-source <FILE> is missing to pass tests.

I cannot understand where is the place to do that from current code.

@oech3 oech3 force-pushed the sorth branch 3 times, most recently from eea9564 to b525e46 Compare February 4, 2026 20:11
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants