Add sticky choice option for leastping#3621
Merged
xiaokangwang merged 1 commit intov2fly:masterfrom Feb 15, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3621 +/- ##
==========================================
- Coverage 23.21% 23.17% -0.04%
==========================================
Files 836 836
Lines 45454 45466 +12
==========================================
- Hits 10552 10539 -13
- Misses 33685 33707 +22
- Partials 1217 1220 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(AI Generated Summary)
This pull request adds a new "sticky choice" feature to the
StrategyLeastPingConfigload balancing strategy. This feature allows the strategy to remember and reuse the last selected outbound when enabled, potentially improving connection stability. The implementation introduces a new configuration field, updates the protobuf definitions and generated code, and modifies the strategy logic to support this behavior.Sticky choice feature for least ping strategy:
sticky_choiceboolean field to theStrategyLeastPingConfigprotobuf message and regenerated the corresponding Go code to include this option. [1] [2] [3] [4]LeastPingStrategystruct instrategy_leastping.goto include a mutex and alastChoicefield for thread-safe tracking of the last selected outbound. [1] [2]PickOutboundmethod to reuse the last selected outbound ifsticky_choiceis enabled and no new outbound is selected, ensuring thread safety with locking.