Delete CppGC teardown code#213
Merged
victorgomes merged 1 commit intov8:node-ci-2025-01-20from Mar 5, 2025
Merged
Conversation
V8 is doing the teardown now, so there is no need for node to do it.
pthier
pushed a commit
that referenced
this pull request
Mar 17, 2025
V8 is doing the teardown now, so there is no need for node to do it.
pthier
pushed a commit
that referenced
this pull request
Jun 27, 2025
V8 is doing the teardown now, so there is no need for node to do it.
pthier
pushed a commit
that referenced
this pull request
Aug 21, 2025
V8 is doing the teardown now, so there is no need for node to do it.
victorgomes
pushed a commit
that referenced
this pull request
Sep 26, 2025
V8 is doing the teardown now, so there is no need for node to do it.
pthier
pushed a commit
that referenced
this pull request
Nov 21, 2025
V8 is doing the teardown now, so there is no need for node to do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 is doing the teardown now, so there is no need for node to do it.