Add context accessor functions for error status and string#209
Draft
bjosv wants to merge 6 commits intovalkey-io:mainfrom
Draft
Add context accessor functions for error status and string#209bjosv wants to merge 6 commits intovalkey-io:mainfrom
bjosv wants to merge 6 commits intovalkey-io:mainfrom
Conversation
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
git ls-files examples/cluster* | xargs sed -i 's|acc->errstr|valkeyClusterAsyncGetErrorString(acc)|g' git ls-files examples/cluster* | xargs sed -i 's|acc->err|valkeyClusterAsyncGetError(acc)|g' git ls-files examples/cluster* | xargs sed -i 's|cc->errstr|valkeyClusterGetErrorString(cc)|g' git ls-files examples/cluster* | xargs sed -i 's|cc->err|valkeyClusterGetError(cc)|g' git ls-files examples/async* | xargs sed -i 's|ac->errstr|valkeyAsyncGetErrorString(ac)|g' git ls-files examples/async* | xargs sed -i 's|ac->err|valkeyAsyncGetError(ac)|g' git ls-files examples/async* | xargs sed -i 's|c->errstr|valkeyAsyncGetErrorString(c)|g' git ls-files examples/async* | xargs sed -i 's|c->err|valkeyAsyncGetError(c)|g' git ls-files examples | xargs sed -i 's|ac->errstr|valkeyAsyncGetErrorString(ac)|g' git ls-files examples | xargs sed -i 's|ac->err|valkeyAsyncGetError(ac)|g' git ls-files examples | xargs sed -i 's|c->errstr|valkeyGetErrorString(c)|g' git ls-files examples | xargs sed -i 's|c->err|valkeyGetError(c)|g' Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Collaborator
Author
|
The following naming variant has also been mentioned in issues/discussions: int valkeyContextGetErr(const valkeyContext *c);
const char *valkeyContextGetErrStr(const valkeyContext *c); |
michael-grunder
approved these changes
May 21, 2025
Collaborator
michael-grunder
left a comment
There was a problem hiding this comment.
Works for me. I think the naming is good too. Probably not worth saving a few characters going to Err.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add accessor functions to get the error status and string from contexts.
These functions replaces any direct access to
erranderrstr, and is a preparation for making contexts opaque.Proposed naming:
Examples and tests have been updated, but READMEs needs to be updated too.