-
Notifications
You must be signed in to change notification settings - Fork 4
Testing link checker #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aryex
wants to merge
29
commits into
main
Choose a base branch
from
alexl/fix-link-checker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Testing link checker #133
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
2b9c078
Add broken link
Aryex 998553e
add ls path
Aryex cfc8d9c
added explicit config path
Aryex 2a6defa
disabled client doc builds
Aryex c1b7625
fixed arg order
Aryex 74b942e
added debug info
Aryex 8319416
fixed args
Aryex f376216
versbose output
Aryex 91a9722
updated arg rules
Aryex 8387d02
Moved arg positions
Aryex bbe8176
fixed glob pattern
Aryex 71d7b9b
Added working directory
Aryex f93df98
fixed lychee
Aryex 9293f0c
forced link check specific file
Aryex 1c0f9b0
added result file print
Aryex 91c02aa
fixed root-dir option
Aryex 927cc69
updated cat
Aryex 0810a9f
added base
Aryex 392560b
used snap iinstead to install lychee
Aryex dea543a
updated to manual lychee check
Aryex c1fd7dc
removed all-pages
Aryex 3ec555d
undo link changes
Aryex d9d7268
restored ci-cd yml
Aryex 0a9123e
fixed comment
Aryex 713ae57
fixed white space
Aryex 8c2dc94
Removed sudo
Aryex 4dac717
added back sudo
Aryex 48e0aeb
trying lychee actio again
Aryex 27bb319
restoring to using snap install lychee
Aryex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need to add a comment saying what was happening previously. Just describe what happen in the current step
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think people will inevitably ask "Why not use lychee-action" for this, so it's good to have this comment to avoid people backtracking on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least we should pin the lychee version
Is it worth it open an issue to investigate why we can't use the action? is a problem of the action itself. I wonder if we should open an issue to the original repo