Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,12 @@ jobs:
uses: withastro/action@v4
with:
package-manager: pnpm@10

# We previously could not make lycheeverse/lychee-action@v2 work;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to add a comment saying what was happening previously. Just describe what happen in the current step

Copy link
Collaborator Author

@Aryex Aryex Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think people will inevitably ask "Why not use lychee-action" for this, so it's good to have this comment to avoid people backtracking on this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least we should pin the lychee version

Is it worth it open an issue to investigate why we can't use the action? is a problem of the action itself. I wonder if we should open an issue to the original repo

# It was not picking up the links in our repo. Thus we are now
# installing and running lychee manually.
- name: Install lychee
run: sudo snap install lychee

- name: Check Links
uses: lycheeverse/lychee-action@v2.7.0
with:
args: ${{ github.workspace }}/dist --root-dir ${{ github.workspace }}/dist
# Fail the pipeline if broken links are found
fail: true
run: pnpm run check-links
147 changes: 0 additions & 147 deletions src/pages/all-pages.astro

This file was deleted.