Conversation
bjosv
reviewed
Oct 10, 2025
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Sorry for late review.. looks good. Added some comments to chat about
|
|
||
| // Override resource requirements for each pod | ||
| // +optional | ||
| Resources corev1.ResourceRequirements `json:"resources,omitempty"` |
Collaborator
There was a problem hiding this comment.
This isn't a ptr compared to the Affinity option that also is optional.
Is this to be handled differently then checking it for nil?
Collaborator
Author
There was a problem hiding this comment.
No I'll clean it up
Collaborator
Author
There was a problem hiding this comment.
There seems to be an issue with Deepcopy, the linter throws an error if we try to make resource requirements a pointer
https://github.com/valkey-io/valkey-operator/actions/runs/18779683212/job/53582458472?pr=5#step:4:34
bjosv
reviewed
Oct 10, 2025
Signed-off-by: Dan Molik <dan@hyperspike.io>
jdheyburn
reviewed
Oct 24, 2025
bjosv
added a commit
that referenced
this pull request
Dec 2, 2025
As discussed in #5 (comment) Example: ``` spec: image: valkey/valkey:8.1.3 shards: 4 replicas: 2 exporter: image: myname/my-exporter:latest resources: # ... resources go here ``` --------- Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Molik dan@hyperspike.io