fix: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白 #7516

MrLeo · 2026-02-04T09:17:57Z

Description

当 showToolbar 为 false 时禁用工具栏，减少无 Toolbar 的 Gird 留白

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

Summary by CodeRabbit

Bug Fixes
- Ensures the toolbar is explicitly disabled when it should not be shown, preventing hidden toolbar controls from remaining active or affecting layout and interactions. This fixes visual/state inconsistencies and improves reliability when toolbar display is toggled.

changeset-bot · 2026-02-04T09:18:04Z

⚠️ No Changeset found

Latest commit: 6fd426d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-04T09:18:22Z

📝 Walkthrough

Walkthrough

A single-line change in the vxe-grid toolbar computation now explicitly sets toolbarConfig.enabled = false when showToolbar is false, ensuring the toolbar is explicitly disabled instead of relying on implicit defaults.

Changes

Cohort / File(s)	Summary
Toolbar Configuration `packages/effects/plugins/src/vxe-table/use-vxe-grid.vue`	When `showToolbar` is false, assigns `toolbarConfig.enabled = false` before returning to explicitly disable the toolbar.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

fix: grid tools in toolbar config not working as expected #5190: Modifies the same toolbar configuration computation in use-vxe-grid.vue, addressing toolbarOptions and tool handling.

Suggested reviewers

anncwb
vince292007
mynetfan

Poem

🐰 A small change, a gentle hop,
One line tells the toolbar: stop.
No more guessing, clear and bright,
Disabled now, snug and right. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: disabling the toolbar when showToolbar is false to reduce whitespace in grids without a toolbar in vxe-table.
Description check	✅ Passed	The description follows the required template with a clear description, identifies it as a bug fix, and completes all checklist items, though it lacks detailed technical explanation of the implementation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@packages/effects/plugins/src/vxe-table/use-vxe-grid.vue`:
- Around line 167-169: The current early return disables the toolbar whenever
showToolbar.value is false, which misses cases where toolbarConfig.tools (from
gridOptions.toolbarConfig.tools) contains user-provided tools; update the guard
in use-vxe-grid (where showToolbar and toolbarConfig are used) to only disable
the toolbar if there is truly no content — i.e., check both showToolbar.value
and that toolbarConfig.tools is empty/undefined before setting
toolbarConfig.enabled = false and returning; ensure the logic references
toolbarConfig.tools (and gridOptions.toolbarConfig.tools) so configured tools
keep the toolbar visible.

coderabbitai · 2026-02-04T09:21:57Z

packages/effects/plugins/src/vxe-table/use-vxe-grid.vue

  if (!showToolbar.value) {
+    toolbarConfig.enabled = false;
    return { toolbarConfig };


⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

cat -n packages/effects/plugins/src/vxe-table/use-vxe-grid.vue | head -200

Repository: vbenjs/vue-vben-admin

Length of output: 6563

🏁 Script executed:

# Get more context around lines 167-169 to verify the complete logic sed -n '140,180p' packages/effects/plugins/src/vxe-table/use-vxe-grid.vue | cat -n

Repository: vbenjs/vue-vben-admin

Length of output: 1579

Avoid disabling toolbar when tools are configured.

showToolbar only checks for slots and table title, ignoring toolbarConfig.tools. When users provide tools via gridOptions.toolbarConfig.tools but without any toolbar slots or table title, the toolbar gets disabled despite having configured content, hiding user actions and the search toggle. Gate the disable on actual toolbar content.

🔧 Proposed fix (guard with tools presence)

- if (!showToolbar.value) { + const hasToolbarContent = + showToolbar.value || + (Array.isArray(toolbarConfig.tools) && toolbarConfig.tools.length > 0); + + if (!hasToolbarContent) { toolbarConfig.enabled = false; return { toolbarConfig }; }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

if (!showToolbar.value) {

toolbarConfig.enabled = false;

return { toolbarConfig };

const hasToolbarContent =

showToolbar.value ||

(Array.isArray(toolbarConfig.tools) && toolbarConfig.tools.length > 0);

if (!hasToolbarContent) {

toolbarConfig.enabled = false;

return { toolbarConfig };

🤖 Prompt for AI Agents

In `@packages/effects/plugins/src/vxe-table/use-vxe-grid.vue` around lines 167 - 169, The current early return disables the toolbar whenever showToolbar.value is false, which misses cases where toolbarConfig.tools (from gridOptions.toolbarConfig.tools) contains user-provided tools; update the guard in use-vxe-grid (where showToolbar and toolbarConfig are used) to only disable the toolbar if there is truly no content — i.e., check both showToolbar.value and that toolbarConfig.tools is empty/undefined before setting toolbarConfig.enabled = false and returning; ensure the logic references toolbarConfig.tools (and gridOptions.toolbarConfig.tools) so configured tools keep the toolbar visible.

doraemonxxx · 2026-02-04T10:54:20Z

this should be "fix" not "refactor"

MrLeo · 2026-02-04T14:22:58Z

this should be "fix" not "refactor"

ok, I have modified the commit message

MrLeo requested review from anncwb, jinmao88, mynetfan and vince292007 as code owners February 4, 2026 09:17

coderabbitai bot reviewed Feb 4, 2026

View reviewed changes

MrLeo changed the title ~~vxe-table: 当 showToolbar 为 false 时禁用工具栏，减少无 Toolbar 的 Gird 留白~~ refactor: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白 Feb 4, 2026

fix: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白

6fd426d

MrLeo force-pushed the main branch from 521f037 to 6fd426d Compare February 4, 2026 14:20

MrLeo changed the title ~~refactor: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白~~ fix: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白 Feb 4, 2026

jinmao88 merged commit 8f4f27d into vbenjs:main Feb 6, 2026
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白 #7516

fix: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白 #7516

MrLeo commented Feb 4, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Feb 4, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 4, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Feb 4, 2026

Uh oh!

doraemonxxx commented Feb 4, 2026

Uh oh!

MrLeo commented Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白 #7516

fix: 当 showToolbar 为 false 时禁用工具栏(vxe-table)，减少无 Toolbar 的 Gird 留白 #7516

Conversation

MrLeo commented Feb 4, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

doraemonxxx commented Feb 4, 2026

Uh oh!

MrLeo commented Feb 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MrLeo commented Feb 4, 2026 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Feb 4, 2026 •

edited

Loading

coderabbitai bot commented Feb 4, 2026 •

edited

Loading