Open
Conversation
Owner
|
Nice work! Please give me some more time to review. |
|
Please treat this as the gentlest possible nudge to move this along in the direction of merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, nice implementation of snowflake IDs! 🙌
Thought I'd throw in some
mypysupport.datetimetodtto fixdatetime()property scope conflictmypydependency withtypes-requestsstrictmypyruletestsfolder frommypytype-checkingpy.typedfile to indicate that typing is enabled on this project for consumerspytest.iniwith equivalentpyproject.tomlrulesIf this is useful, I'm also happy to add in some pre-commit hooks and GitHub workflows?
May also be a good idea to have some linting in place as well - I'm happy to set up
ruffin a separate PR if interested?