large(ish) files were not working#69
Conversation
|
@robertlyates is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| .join(""); | ||
| } | ||
| if (encoding === "binary" || encoding === "latin1") { | ||
| return String.fromCharCode(...buffer); |
There was a problem hiding this comment.
Base64 encoding in fromBuffer fails with large buffers (>100KB) due to JavaScript call stack limit when using String.fromCharCode(...buffer) spread operator.
There was a problem hiding this comment.
yes, that is what i removed, this is an agent review of the diff and it's looking at the old code (which I removed)
|
@cramforce any chance you could take a quick look at this and merge if possible, issue is here - #71 |
|
Looks good. Can you address the spread comment? |
|
Could you provide a list of failing commands? And just want to make sure you are aware that you can use custom commands to get this into your own agent |
i assume you mean the agent's review, it's comment is based on the old code, it seems to be reviewing the diff and it's seeing the removed lines. The problem that it is recognizing is what I removed. |
i think this is meant for the other PR i.e. #84 will continue the conversation over there |
|
Could you fix lint |
|
fixed the linting errors, apologies |
3 participants
i have been looking to use just-bash with modestly sized files e.g. around 0.5 MB and running into various challenges
the core issues stem from the use of the spread operator which runs into limits
i have replaced the ones I have found so far with equivalent buffer operations