fix(ui): prevent TypeError in onFinish when activeResponse is undefined#12207
Open
codewithkenzo wants to merge 1 commit intovercel:mainfrom
Open
fix(ui): prevent TypeError in onFinish when activeResponse is undefined#12207codewithkenzo wants to merge 1 commit intovercel:mainfrom
codewithkenzo wants to merge 1 commit intovercel:mainfrom
Conversation
Use local variable capture pattern in makeRequest() to safely access activeResponse in the finally block. This prevents 'Cannot read properties of undefined' errors when: - An error is thrown before activeResponse is assigned - Concurrent makeRequest calls overwrite this.activeResponse Fixes vercel#8477 Thanks to @codybrouwers for identifying the root cause and solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When using
useChatwithonFinishcallback andresumeenabled, users encounter:This happens because
this.activeResponsein thefinallyblock can be:makeRequestcallsSummary
Use local variable capture pattern to safely reference
activeResponsein the finally block:let activeResponsebefore try blockthis.activeResponseonFinishThis is a well-established pattern for try-finally resource management (see TypeScript #28153).
Manual Verification
Build passes locally. The fix is minimal and follows the exact pattern suggested by @codybrouwers in the issue comments, which multiple users confirmed works via
patch-package.Checklist
pnpm changesetin the project root)Related Issues
Fixes #8477
Thanks to @codybrouwers for identifying the root cause and providing the solution.