Solve issue #40 cmake version issue for above 3.5 version#41
Closed
mominfaizan wants to merge 1 commit intovietjtnguyen:masterfrom
Closed
Solve issue #40 cmake version issue for above 3.5 version#41mominfaizan wants to merge 1 commit intovietjtnguyen:masterfrom
mominfaizan wants to merge 1 commit intovietjtnguyen:masterfrom
Conversation
Owner
|
Thanks for the PR. Can you rename the branch to conform with existing convention: Also I've tried against CMake 3.25.1 (current version in Debian Bookworm) and don't see any issues so I don't see why not updating the max version to that. |
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required( VERSION 3.0 ) | |||
| cmake_minimum_required( VERSION 3.0...3.5) | |||
Owner
There was a problem hiding this comment.
Can you also maintain formatting conventions with the space prior to trailing closing parenthesis?
Author
|
yes will look into it and the reason for providing a range is that a user can use the whole range(3.0 to 3.5) rather than just giving max value(3.25) which again leads to an error for user with older cmake version(ex: user with 3.1 version).
…On Tue, Apr 15, 2025, 5:07 AM Viet Nguyen ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CMakeLists.txt
<#41 (comment)>:
> @@ -1,4 +1,4 @@
-cmake_minimum_required( VERSION 3.0 )
+cmake_minimum_required( VERSION 3.0...3.5)
Can you also maintain formatting conventions with the space prior to
trailing closing parenthesis?
—
Reply to this email directly, view it on GitHub
<#41 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2H2ZRZ2746J62OCJ5ECWZ32ZRBCVAVCNFSM6AAAAAB3CEQHAWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONRWGA2DAMJTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Closed in favor of #44 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves a compatibility issue with CMake 4.0.0. The original CMakeLists.txt specified cmake_minimum_required(VERSION 3.1), which is no longer supported in CMake 4.0+. As a result, configuration would fail with an error regarding outdated compatibility.
Fixes: #40
🛠️ Changes Made
Updated cmake_minimum_required(VERSION 3.1...3.5) to VERSION 3.5 to meet the new minimum requirements introduced in CMake 4.0.0 and also able to run VERSION 3.1 to 3.5. So it will also run on older version.
Ensured that no other parts of the configuration were impacted by this version change.
🧪 Testing
Successfully ran make with CMake 4.0.0.
Verified that the project configures, builds, and installs correctly.
📦 Related
Let me know if you'd like to add a screenshot of the error, mention others, or reference additional issues/branches!