Open
Conversation
Collaborator
palanc
commented
May 1, 2023
palanc
commented
- Update existing push env to use cartesian action space
- Add new pushing envs
- All pushing envs use robotiq gripper. See additional PR here for gripper updates: Additional joint constraints robotiq_sim#1
added 2 commits
May 1, 2023 14:33
vikashplus
reviewed
May 1, 2023
Owner
vikashplus
left a comment
vikashplus
left a comment
There was a problem hiding this comment.
This seems like a larger refactor. See comments inline
| # device1: sensors, actuators | ||
| 'franka':{ | ||
| 'interface': {'type': 'franka', 'ip_address':'169.254.163.91'}, | ||
| 'interface': {'type': 'franka', 'ip_address':'172.16.0.1', 'gain_scale': 1.5}, |
Owner
There was a problem hiding this comment.
Scale can only be a max of 1.0
| <include file="../../../../simhive/scene_sim/topfloor_scene.xml"/> | ||
| <include file="../../../../simhive/franka_sim/assets/assets.xml"/> | ||
| <include file="../../../../simhive/franka_sim/assets/gripper_assets.xml"/> | ||
| <include file="../../../../simhive/robotiq_sim/assets/assets.xml"/> |
Owner
There was a problem hiding this comment.
Note that this is franka robot. Adding RobotiQ will cause confusion. We should create a new file for this and name it appropriately.
| @@ -25,6 +30,27 @@ class PushBaseV0(env_base.MujocoEnv): | |||
|
|
|||
| def __init__(self, model_path, obsd_model_path=None, seed=None, **kwargs): | |||
Owner
There was a problem hiding this comment.
Currently it looks like, the original env is being replaced by this new IK based env. Right? I think the right way to implement this is to
- define a new act mode called IK
- Once the robot receives
ctrl_desiredin the step, it relies on the process-actuator call to do the translation from ee space to jnt space. - I also think the action space definitions needs to be updated if its IK space
In summary, landing this in a generic way seems to require a rather larger refactor (possibly involving a refactor of the robot class). Let me know if should discuss this before going down this route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.