fix: Windows compatibility - USERPROFILE fallback and TCP socket on win32#6
Open
NeKoOuO wants to merge 1 commit intovikasprogrammer:mainfrom
Open
fix: Windows compatibility - USERPROFILE fallback and TCP socket on win32#6NeKoOuO wants to merge 1 commit intovikasprogrammer:mainfrom
NeKoOuO wants to merge 1 commit intovikasprogrammer:mainfrom
Conversation
ed72f14 to
4237298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two bugs prevent walkie-sh from running on Windows:
Bug 1: \process.env.HOME\ is undefined on Windows
Both \src/client.js\ and \src/daemon.js\ used \process.env.HOME\ which is \undefined\ on Windows (the correct variable is \USERPROFILE). Node.js v24 throws \TypeError [ERR_INVALID_ARG_TYPE]\ when \path.join\ receives \undefined.
Bug 2: Unix domain socket not supported on Windows
The daemon uses .sock\ files for IPC, which are Unix-only. On Windows this silently fails with 'Failed to start walkie daemon'.
Fix
Closes #5