Skip to content

Migrate to monorepo#2459

Merged
Pessimistress merged 9 commits intomasterfrom
next
Jan 28, 2025
Merged

Migrate to monorepo#2459
Pessimistress merged 9 commits intomasterfrom
next

Conversation

@Pessimistress
Copy link
Collaborator

For #2457

  • /src -> /modules/main/src
  • /test/src -> /modules/main/test
  • Upgrade to latest dev tools
  • Use browser test for coverage. Remove polyfill for node-based component tests.
  • Placeholder for react-maplibre and react-mapbox packages
  • Build, lint and test should be working
  • Website is broken

@nilsingwersen
Copy link

Now that the repo migrates to a monorepo, are yarn and lerna set as tools that will be used?

@Pessimistress
Copy link
Collaborator Author

@nilsingwersen are you asking as a user or a contributor? Development has always used yarn.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legacy code path is only kept for Mapbox. I will do another round of clean up.

@nilsingwersen
Copy link

@nilsingwersen are you asking as a user or a contributor? Development has always used yarn.

I was just thinking about contributing and was curious about this especially because lerna is now owned by the nx folks.

@Pessimistress
Copy link
Collaborator Author

lerna is now owned by the nx folks

If this a concern of yours, can you point me to some article/discussion about it?
We've been using lerna in other vis.gl projects for at least 6 years.

@nilsingwersen
Copy link

Not a concern at all, as I said I was just curious.

@Pessimistress Pessimistress merged commit 0a710b4 into master Jan 28, 2025
1 check passed
@Pessimistress Pessimistress deleted the next branch January 28, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants