Merged
Conversation
chrisgervang
approved these changes
Jan 24, 2025
|
|
||
| Note: props in this section are not reactive. They are only used once when the Map instance is constructed. | ||
|
|
||
| #### `mapLib`: any {#maplib} |
Contributor
There was a problem hiding this comment.
Just to confirm, this prop still exists?
Is there any type inference from its value?
I'm looking at Hubble.gl right now as an example of a library compatible with both maplibre and mapbox, so I'll be looking at how common types flow into the maps.
I don't think libs should use mapLib (instead, use either top-level Map component).
Collaborator
Author
There was a problem hiding this comment.
Users can still use mapLib to control how they include the base map library:
- In the same bundle (
import maplibregl from 'maplibre-gl'thenmapLib={maplibregl}) - Split bundle (
mapLib={import('maplibre-gl')}) - Script tag (
mapLib={window.maplibregl})
Pessimistress
added a commit
that referenced
this pull request
Jan 28, 2025
Pessimistress
added a commit
that referenced
this pull request
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split API reference into separate sections for Mapbox and Maplibre