feat: remove RTLTextPlugin default for MapLibre#2480
Merged
Pessimistress merged 3 commits intovisgl:masterfrom Jan 31, 2025
Merged
feat: remove RTLTextPlugin default for MapLibre#2480Pessimistress merged 3 commits intovisgl:masterfrom
RTLTextPlugin default for MapLibre#2480Pessimistress merged 3 commits intovisgl:masterfrom
Conversation
Pessimistress
approved these changes
Jan 30, 2025
Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed previously, I've removed the default value for the
RTLTextPluginwhich loaded from mapbox.com. This aligns more closely to the default behavior of the maplib, forcing the user to manually set such url. The prop now also accepts an object, to allow full configuration of thesetRTLTextPlugincall.This implements the proper fix towards #2310
BREAKING CHANGE:
RTLTextPluginmust now be set manually as prop