Fix type resolution for subpath exports when using moduleResolution: node#2486
Merged
Pessimistress merged 1 commit intovisgl:masterfrom Feb 7, 2025
connor-baer:fix/type-exports
Merged
Fix type resolution for subpath exports when using moduleResolution: node#2486Pessimistress merged 1 commit intovisgl:masterfrom connor-baer:fix/type-exports
moduleResolution: node#2486Pessimistress merged 1 commit intovisgl:masterfrom
connor-baer:fix/type-exports
Conversation
Pessimistress
pushed a commit
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript isn't able to resolve the types for subpath exports (e.g.
react-map-gl/mapbox) when usingmoduleResolution: nodein consuming apps (see this StackOverflow issue).Adding
typesVersionswith*to target all TypeScript versions works around this limitation.