(fix #21456): ensure css-only entries are marked as isEntry

packages/vite/src/node/plugins/manifest.ts

@@ -1,4 +1,5 @@
 import path from 'node:path'
+import fs from 'node:fs'
 import type { OutputAsset, OutputChunk, RenderedChunk } from 'rolldown'
 import { viteManifestPlugin as nativeManifestPlugin } from 'rolldown/experimental'
 import type { Plugin } from '../plugin'
@@ -145,6 +146,37 @@ export function manifestPlugin(config: ResolvedConfig): Plugin {
                   }
                 }
               }
+
+              // Ensure that all input files are marked as entries in the manifest
+              // This is necessary because Rollup may not mark pure css chunks as entries
+              // when using array-based input
+              const rawInput = environment.config.build.rollupOptions.input
+              if (manifest && rawInput) {
+                const root = environment.config.root
+                const inputList =
+                  typeof rawInput === 'string'
+                    ? [rawInput]
+                    : Array.isArray(rawInput)
+                      ? rawInput
+                      : Object.values(rawInput)
+
+                const inputEntries = new Set<string>()
+                for (const input of inputList) {
+                  const absoluteInput = path.resolve(root, input)
+                  const relativeInput = normalizePath(
+                    path.relative(root, absoluteInput),
+                  )
+                  inputEntries.add(relativeInput)
+                }
+
+                for (const key in manifest) {
+                  const item = manifest[key]
+                  if (!item.isEntry && item.src && inputEntries.has(item.src)) {
+                    item.isEntry = true
+                  }
+                }
+              }
+
               const output =
                 this.environment.config.build.rolldownOptions.output
               const outputLength = Array.isArray(output) ? output.length : 1
@@ -167,6 +199,54 @@ export function manifestPlugin(config: ResolvedConfig): Plugin {
               }
             }
           },
+          async writeBundle() {
+            const outDir = environment.config.build.outDir
+            const manifestPath = path.resolve(root, outDir, outPath)
+            if (!fs.existsSync(manifestPath)) return
+
+            let manifest: Manifest
+            try {
+              manifest = JSON.parse(fs.readFileSync(manifestPath, 'utf-8'))
+            } catch (_e) {
+              return
+            }
+
+            const rawInput = environment.config.build.rollupOptions.input
+            if (manifest && rawInput) {
+              const root = environment.config.root
+              const inputList =
+                typeof rawInput === 'string'
+                  ? [rawInput]
+                  : Array.isArray(rawInput)
+                    ? rawInput
+                    : Object.values(rawInput)
+
+              const inputEntries = new Set<string>()
+              for (const input of inputList) {
+                const absoluteInput = path.resolve(root, input)
+                const relativeInput = normalizePath(
+                  path.relative(root, absoluteInput),
+                )
+                inputEntries.add(relativeInput)
+              }
+
+              let changed = false
+              for (const key in manifest) {
+                const item = manifest[key]
+                if (!item.isEntry && item.src && inputEntries.has(item.src)) {
+                  item.isEntry = true
+                  changed = true
+                }
+              }
+
+              if (changed) {
+                fs.writeFileSync(
+                  manifestPath,
+                  JSON.stringify(manifest, null, 2),
+                )
+              }
+            }
+          },
         },
       ]
     })
@@ -315,6 +395,34 @@ export function manifestPlugin(config: ResolvedConfig): Plugin {
         }
       }
 
+      // Ensure that all input files are marked as entries in the manifest
+      // This is necessary because Rollup may not mark pure css chunks as entries
+      // when using array-based input
+      const inputOptions = buildOptions.rollupOptions.input
+      if (inputOptions) {
+        const inputs = new Set<string>()
+        const inputList = Array.isArray(inputOptions)
+          ? inputOptions
+          : typeof inputOptions === 'object'
+            ? Object.values(inputOptions)
+            : [inputOptions]
+
+        for (const input of inputList) {
+          const absoluteInput = path.resolve(root, input)
+          const relativeInput = normalizePath(
+            path.relative(root, absoluteInput),
+          )
+          inputs.add(relativeInput)
+        }
+
+        for (const name in manifest) {
+          const item = manifest[name]
+          if (!item.isEntry && item.src && inputs.has(item.src)) {
+            item.isEntry = true
+          }
+        }
+      }
+
       state.outputCount++
       const output = buildOptions.rollupOptions.output
       const outputLength = Array.isArray(output) ? output.length : 1

playground/fs-serve/__tests__/fs-serve.spec.ts

@@ -379,7 +379,14 @@ describe('cross origin', () => {
     let page2: Page
     beforeEach(async () => {
       page2 = await browser.newPage()
-      await page2.goto('http://vite.dev/404')
+      await page2.route(/^http:\/\/example\.com/, async (route) => {
+        await route.fulfill({
+          status: 200,
+          contentType: 'text/html',
+          body: '<html><body>External Origin</body></html>',
+        })
+      })
+      await page2.goto('http://example.com/404')
     })
     afterEach(async () => {
       await page2.close()

playground/manifest-css-entry/__tests__/manifest-css-entry.spec.ts

@@ -0,0 +1,11 @@
+import { describe, expect, test } from 'vitest'
+import { isBuild, readManifest } from '~utils'
+
+describe.runIf(isBuild)('manifest-css-entry', () => {
+  test('import-only css entry should have isEntry: true', () => {
+    const manifest = readManifest()
+    const mainCssEntry = manifest['frontend/entrypoints/main.css']
+    expect(mainCssEntry).toBeDefined()
+    expect(mainCssEntry.isEntry).toBe(true)
+  })
+})

playground/manifest-css-entry/frontend/entrypoints/main.css

@@ -0,0 +1,2 @@
+@import './styles/theme.css';
+@import './styles/main.css';

playground/manifest-css-entry/frontend/entrypoints/main.js

@@ -0,0 +1 @@
+console.log('main.js')

playground/manifest-css-entry/frontend/entrypoints/styles/main.css

@@ -0,0 +1,4 @@
+/* styles/main.css */
+body {
+  color: red;
+}

playground/manifest-css-entry/frontend/entrypoints/styles/theme.css

@@ -0,0 +1,4 @@
+/* styles/theme.css */
+:root {
+  --primary: blue;
+}

playground/manifest-css-entry/vite.config.js

@@ -0,0 +1,16 @@
+import { defineConfig } from 'vite'
+import path from 'node:path'
+
+export default defineConfig({
+  build: {
+    manifest: true,
+    rollupOptions: {
+      input: [
+        path.resolve(__dirname, 'frontend/entrypoints/main.css'),
+        path.resolve(__dirname, 'frontend/entrypoints/main.js'),
+        path.resolve(__dirname, 'frontend/entrypoints/styles/main.css'),
+        path.resolve(__dirname, 'frontend/entrypoints/styles/theme.css'),
+      ],
+    },
+  },
+})